Re: [Xen-devel] [PATCH RFC OSSTEST v1 07/12] ts-debian-di-install: Allow Di Version to come from runvars

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH RFC OSSTEST v1 07/12] ts-debian-di-install: Allow 
Di Version to come from runvars"):
> and following the lead of the suite arrange for a version selected
> from the defaults to be written back to the runvars.
...
> -                      debian_guest_suite
> +                      debian_guest_suite debian_guest_diversion

Can we please call this function, ..._di_version ?  Otherwise it sounds
very much like something is being diverted.

> +sub debian_guest_diversion ($) {
> +    my ($gho) = @_;
> +
> +    $gho->{DiVersion} //= guest_var($gho,'diversion',undef);
> +
> +    if (!$gho->{DiVersion}) {
> +     $gho->{DiVersion} = $c{TftpDiVersion};
> +     store_runvar("$gho->{Guest}_diversion", $gho->{DiVersion});

I'm not sure what we should do about the runvar.  `diversion' is a bad
name but there is a risk with `..._di_version' getting confused with
all the `..._revision' fields.

OTOH

osstestdb=> select distinct name from runvars where name like '%version';
         name
         ----------------------
          device_model_version
          (1 row)

osstestdb=>

So maybe guest_di_version would be the right answer.

Aside from the questions about this name, this patch LGTM.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel