Re: [Xen-devel] [PATCH v5 2/2] xen_balloon: support memory auto onlining policy

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Wed, Jan 13, 2016 at 06:32:30PM +0100, Vitaly Kuznetsov wrote:
> Add support for the newly added kernel memory auto onlining policy to Xen
> ballon driver.
>
> Suggested-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>

In general Reviewed-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
but one nitpick below...

Thank you for doing this work.

> ---
> Changes since v4:
> - 'dom0' -> 'control domain', 'domU' -> 'target domain' in Kconfig
>   [David Vrabel]
> - always call add_memory_resource() with memhp_auto_online [David Vrabel]
> ---
>  drivers/xen/Kconfig   | 20 +++++++++++++-------
>  drivers/xen/balloon.c | 11 ++++++++++-
>  2 files changed, 23 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
> index 73708ac..addcb7f 100644
> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -37,23 +37,29 @@ config XEN_BALLOON_MEMORY_HOTPLUG
>
>         Memory could be hotplugged in following steps:
>
> -         1) dom0: xl mem-max <domU> <maxmem>
> +         1) target domain: ensure that memory auto online policy is in
> +            effect by checking /sys/devices/system/memory/auto_online_blocks
> +            file (should be 'online').
> +
> +         2) control domain: xl mem-max <target-domain> <maxmem>
>              where <maxmem> is >= requested memory size,
>
> -         2) dom0: xl mem-set <domU> <memory>
> +         3) control domain: xl mem-set <target-domain> <memory>
>              where <memory> is requested memory size; alternatively memory
>              could be added by writing proper value to
>              /sys/devices/system/xen_memory/xen_memory0/target or
>              /sys/devices/system/xen_memory/xen_memory0/target_kb on dumU,

Please change "dumU" to "target domain".

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel