Re: [Xen-devel] [PATCH 26/28] libxl: spawns two QEMUs for HVM guests

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH 26/28] libxl: spawns two QEMUs for HVM 
guests"):
> On Tue, 2015-12-22 at 18:45 +0000, Ian Jackson wrote:
> > @@ -440,6 +442,15 @@ static int domcreate_setdefault_dm_user(libxl__gc
> > *gc,
> > +    if (!libxl__dm_supported(gc, dm,
> > libxl__dm_support_check__emulator_id)) {
> > +        /* we don't want to run the pv backends as non-root because
> > +         * device hotplug will no longer work. */
> > +        LOG(WARN,
> > + "Device model does not support split PV backends, running it as root");
> > +        user = "root";
> > +        goto found;
> > +    }
> 
> Should this be a fatal error, unless b_info->device_model_user == "root"?

This is in the code which sets the default value if the configuration
didn't specify one.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel