Re: [Xen-devel] [PATCH 26/28] libxl: spawns two QEMUs for HVM guests

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-12-22 at 18:45 +0000, Ian Jackson wrote:
> @@ -440,6 +442,15 @@ static int domcreate_setdefault_dm_user(libxl__gc
> *gc,
> ÂÂÂÂÂÂÂÂÂ/* we're not going to run it anyway */
> ÂÂÂÂÂÂÂÂÂreturn 0;
> Â
> +ÂÂÂÂif (!libxl__dm_supported(gc, dm,
> libxl__dm_support_check__emulator_id)) {
> +ÂÂÂÂÂÂÂÂ/* we don't want to run the pv backends as non-root because
> +ÂÂÂÂÂÂÂÂÂ* device hotplug will no longer work. */
> +ÂÂÂÂÂÂÂÂLOG(WARN,
> + "Device model does not support split PV backends, running it as root");
> +ÂÂÂÂÂÂÂÂuser = "root";
> +ÂÂÂÂÂÂÂÂgoto found;
> +ÂÂÂÂ}

Should this be a fatal error, unlessÂb_info->device_model_user == "root"?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel