Re: [Xen-devel] [PATCH v13 5/8] xen: Add vmware_port support

[Don Slutz <don.slutz@xxxxxxxxx>]

On 12/16/15 10:12, Jan Beulich wrote:
>>>> On 28.11.15 at 22:45, <don.slutz@xxxxxxxxx> wrote:
>> ---
>> v13:
>>   Changed to uint32_t arch_flags, since the emulation_flags is this.
> 
> I don't really understand this sentence, and I also don't understand
> why you couldn't just use another XEN_X86_EMU_ flag, e.g.
> XEN_X86_EMU_VMWARE_PORT (which would be the first one outside
> the current all-or-nothing model).
>

Next attempt at that sentence:

During re-base of the patch, changed uint64_t arch_flags to uint32_t
arch_flags.  This appeared to be ok because the added emulation_flags
was a unit32_t.

I have no reason not to use another XEN_X86_EMU_ flag.  It was not clear
when I was re-baseing that it would be ok to do so.

Will drop arch_flags and use XEN_X86_EMU_VMWARE_PORT which will not be
added to "all".

   -Don Slutz


> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel