Re: [Xen-devel] [PATCH v13 2/8] xen: Add support for VMware cpuid leaves

[Don Slutz <don.slutz@xxxxxxxxx>]

On 12/16/15 05:28, Jan Beulich wrote:
>>>> On 28.11.15 at 22:44, <don.slutz@xxxxxxxxx> wrote:
>> --- a/xen/include/public/arch-x86/xen.h
>> +++ b/xen/include/public/arch-x86/xen.h
>> @@ -290,6 +290,7 @@ struct xen_arch_domainconfig {
>>                                       XEN_X86_EMU_VGA | XEN_X86_EMU_IOMMU |  
>>  \
>>                                       XEN_X86_EMU_PIT)
>>      uint32_t emulation_flags;
>> +    uint64_t vmware_hwver;
> 
> It's been a while since the last iteration, so could you please remind
> me again why this needs to be a 64-bit quantity?

Looking at it, it only needs to be a 32-bit quantity.  My memory says
that it was 64-bits because that was the size of a HVM_PARAM_... which
was were it was passed before this code existed.

I see no reason not to change to 32-bit, and so will do so.

   -Don Slutz

> 
> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel