Re: [Xen-devel] [PATCH RFC XEN v1 03/14] xen: arm: switch arch_do_domctl to a common exit path

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-12-15 at 16:34 +0000, Stefano Stabellini wrote:
>Â.. .arch_do_domclt...
> > +
> > +ÂÂÂÂif ( copyback && __copy_to_guest(u_domctl, domctl, 1) )
> > +ÂÂÂÂÂÂÂÂrc = -EFAULT;
> 
> This code is already present in do_domctl (the caller of this function).
> I wonder if it makes sense to pass a copyback* parameter to
> arch_do_domctl and just rely on the caller's exit path.

Could do, cc-ing Jan in addition to Andy for x86 perspective (since this
would be a generic change.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel