Re: [Xen-devel] [OSSTEST PATCH 5/8] Schema: Support database schema updates

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-12-11 at 15:15 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [OSSTEST PATCH 5/8] Schema: Support database
> schema updates"):
> > On Thu, 2015-12-10 at 18:27 +0000, Ian Jackson wrote:
> > > See schema/README.schema, introduced in this patch, for the design.
> > 
> > The README looks good now, thanks.
> 
> Thanks.
> 
> > Code comments....
> 
> > > diff --git a/mg-schema-create b/mg-schema-create
> ...
> > > +export OSSTEST_DB_USEREAL_IGNORETEST='.*'
> > 
> > Why remove the safety catch in this context?
> 
> The safety catch breaks when run on an empty schema, because there is
> no `tasks' table.ÂÂSetting this pattern to `.*' triggers a special
> case which avoids even trying to see what test DBs exist.
> 
> And furthermore the safety catch is not needed because if we are
> mistakenly operating on an existing database (test or real) we bomb
> out as previously discussed.

Thanks for the explanation.

> I can put this in a comment if you like.

I suppose a comment next to any such override is a pretty good policy to
have.

With that: Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel