Re: [Xen-devel] [OSSTEST PATCH 5/8] Schema: Support database schema updates

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-12-10 at 18:27 +0000, Ian Jackson wrote:
> Ian Jackson writes ("Re: [OSSTEST PATCH 5/8] Schema: Support database
> schema updates"):
> > It does say that updates are applied in order.ÂÂI will add `and
> > monotonically increasing' after `unique'.ÂÂ[etc etc]
> 
> Here is v3 of this patch.ÂÂI'll refrain from reposting the whole
> series.
> 
> Ian.
> 
> From a7fe7187f6237043f8d6aedeb714409b606af8e0 Mon Sep 17 00:00:00 2001
> From: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Date: Thu, 10 Dec 2015 13:26:00 +0000
> Subject: [OSSTEST PATCH 5/8] Schema: Support database schema updates
> 
> See schema/README.schema, introduced in this patch, for the design.

The README looks good now, thanks.

Code comments....

[...]

> diff --git a/mg-schema-create b/mg-schema-create
> index 54f1c76..1ee007b 100755
> --- a/mg-schema-create
> +++ b/mg-schema-create
> [...]
> @@ -46,16 +51,31 @@ while [ $# != 0 ]; do
> ÂÂÂÂÂÂÂÂÂprogress=:
> ÂÂÂÂÂÂÂÂÂquietopt=-q
> ÂÂÂÂÂÂÂÂÂ;;
> +ÂÂÂÂ--stop-before|--stop-after)
> +ÂÂÂÂ updates+=("$arg" "$1"); shift
> +     ;;
> +ÂÂÂÂ--stop-before=*|--stop-after=*)
> +ÂÂÂÂ updates+=("$arg"); shift
> +     ;;
> +ÂÂÂÂ--no-updates)
> +ÂÂÂÂ do_updates=false
> +     ;;
> ÂÂÂÂÂ*)
> ÂÂÂÂÂÂÂÂÂecho >&2 "bad usage ($arg)"; exit 127
> ÂÂÂÂÂÂÂÂÂ;;
> ÂÂÂÂÂesac
> Âdone
> Â
> +export OSSTEST_DB_USEREAL_IGNORETEST='.*'

Why remove the safety catch in this context?

... and that seems to be my only comment.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel