Re: [Xen-devel] [PATCH v10 6/7] vmx: VT-d posted-interrupt core logic handling

["Wu, Feng" <feng.wu@xxxxxxxxx>]

> -----Original Message-----
> From: Tian, Kevin
> Sent: Friday, December 11, 2015 10:28 AM
> To: Wu, Feng <feng.wu@xxxxxxxxx>; xen-devel@xxxxxxxxxxxxx
> Cc: Keir Fraser <keir@xxxxxxx>; Jan Beulich <jbeulich@xxxxxxxx>; Andrew
> Cooper <andrew.cooper3@xxxxxxxxxx>; George Dunlap
> <george.dunlap@xxxxxxxxxxxxx>; Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> Subject: RE: [PATCH v10 6/7] vmx: VT-d posted-interrupt core logic handling
> 
> > From: Wu, Feng
> > Sent: Friday, December 11, 2015 9:59 AM
> >
> > > > +void vmx_vcpu_block(struct vcpu *v)
> > > > +{
> > > > +    unsigned long flags;
> > > > +    struct pi_desc *pi_desc = &v->arch.hvm_vmx.pi_desc;
> > > > +
> > > > +    if ( !has_arch_pdevs(v->domain) )
> > > > +        return;
> > > > +
> > > > +    ASSERT(v->arch.hvm_vmx.pi_block_cpu == NR_CPUS);
> > > > +
> > > > +    /*
> > > > +     * The vCPU is blocking, we need to add it to one of the per pCPU 
> > > > lists.
> > > > +     * We save v->processor to v->arch.hvm_vmx.pi_block_cpu and use it
> for
> > > > +     * the per-CPU list, we also save it to posted-interrupt 
> > > > descriptor and
> > > > +     * make it as the destination of the wake-up notification event.
> > >
> > > the 2nd piece - "we also save it to posted-interrupt descriptor" is not
> > > reflected within this function. Do you mean "we have saved it to..."
> > > or "we will save it later to..." in other places?
> 
> what about this question?

Oh, sorry, I didn't notice this comments. Originally, I saved the pCPU 
information
in posted-interrupts descriptor in this function, however, George pointed out
that the NDST filed in posted-interrupts descriptor should have pointed to the
same pCPU, no need to update it again, so I removed the code. Seems I forgot
to update the comments, will do it in the next version, thanks for pointing it 
out!

Thanks,
Feng

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel