Re: [Xen-devel] [PATCH RFC XEN v1 13/14] tools: libxc: wire up migration for ARM

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 09/12/15 14:32, Ian Campbell wrote:
> This seems almost too easy.

I am glad that a healthy quantity of time has passed since the 4.6 dev
window.  Easy is not how I would have described this back then!

> diff --git a/tools/libxc/xc_sr_common_arm.h b/tools/libxc/xc_sr_common_arm.h
> new file mode 100644
> index 0000000..efbea70
> --- /dev/null
> +++ b/tools/libxc/xc_sr_common_arm.h
> @@ -0,0 +1,15 @@
> +#ifndef __COMMON_ARM__H
> +#define __COMMON_ARM__H
> +
> +#include "xc_sr_common.h"
> +
> +#endif
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * tab-width: 4
> + * indent-tabs-mode: nil
> + * End:
> + */

Given how small this is, I would just drop it and include xc_sr_common.h
directly.  It only exists on the x86 side because of the magic TSC
handling which is common between PV and HVM guests.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel