Re: [Xen-devel] [OSSTEST PATCH 03/11] Configuration: No longer set password=<~/.xen-osstest/db-password>

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-12-04 at 19:35 +0000, Ian Jackson wrote:
> Instead, expect the user to provide ~/.pgpass.
> 
> This is a good idea because we don't really want to be handling
> passwords ourselves if we can help it.ÂÂAnd, we are shortly going to
> want to do some exciting mangling of the database access
> configuration, which would be complicated by the presence of this
> password expansion.
> 
> This may break for some users of existing Executive (non-standalone)
> setups which are using production-config-cambridge or the default
> built-in configuration.

I think you need to create a ~osstest/.pgpass in Cambridge before deploying
this.

It seems like there ought to be some docs update, but the existing bit
about DbnamePat in README doesn't mention password already, so I guess that
is ok!

Assuming Cambridge's .pgpass is created:
    Acked-by: Ian Campbell <    ian.campbell@xxxxxxxxxx    >

My personal config seems OK already. I've just moved aside what I think is
a stale db-password so I'll know for sure next time I have play.

We should delete ~osstest/.xen-osstest/db-password once this passes the
Cambridge pushgate, otherwise we'll be confused in 6 months looking at it.

I've added some CC's based on:

osstestdb=> SELECT DISTINCT username FROM tasks;
ÂÂÂÂÂusernameÂÂÂÂÂ
------------------
Â
Ârogerpau@osstest
Âijc@woking
Âiwj@osstest
Âiwj@woking
Âianc@kazak
Âosstest@osstest
Âjulieng@osstest
Âianc@woking
Âianj@osstest
Âiwj@mariner
Â
Âianc@osstest
(13 rows)

osstestdb=>Â

FYI a reasonable .pgpass is:
osstestdb.xs.citrite.net:*:*:<<USERNAME>>:<<YOUR PASSWORD>>
osstestdb:*:*:<<USERNAME>>:<<YOUR PASSWORD>>


> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> ---
> ÂOsstest.pmÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂÂ3 +--
> Âproduction-config-cambridge |ÂÂÂÂ2 +-
> Â2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Osstest.pm b/Osstest.pm
> index ec50d60..95e4d46 100644
> --- a/Osstest.pm
> +++ b/Osstest.pm
> @@ -191,8 +191,7 @@ sub readglobalconfig () {
> Â
> ÂÂÂÂÂ# dynamic default config settings
> ÂÂÂÂÂ$c{ExecutiveDbnamePat} ||= "dbname=<dbname>;user=<whoami>;".
> -     "host=<dbname>.db.$c{DnsDomain};".
> -     "password=<~/.xen-osstest/db-password>"
> +     "host=<dbname>.db.$c{DnsDomain}"
> Â     if defined $c{DnsDomain};
> ÂÂÂÂÂ# 1. <\w+> is replaced with variables:
> ÂÂÂÂÂ#ÂÂÂÂÂÂÂÂÂ<dbname>ÂÂÂÂdatabase name
> diff --git a/production-config-cambridge b/production-config-cambridge
> index f801303..412766c 100644
> --- a/production-config-cambridge
> +++ b/production-config-cambridge
> @@ -23,7 +23,7 @@ HostDB_Executive_NoConfigDB 1
> Â
> ÂOwnerDaemonHost owner.daemon.osstest.xs.citrite.net
> ÂQueueDaemonHost queue.daemon.osstest.xs.citrite.net
> -ExecutiveDbnamePat
> dbname=<dbname>;user=<whoami>;host=osstestdb.xs.citrite.net;password=<~/.
> xen-osstest/db-password>
> +ExecutiveDbnamePat
> dbname=<dbname>;user=<whoami>;host=osstestdb.xs.citrite.net
> Â
> ÂHostnameSortSwapWords 1
> Â

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel