Re: [Xen-devel] [PATCH v2 4/4] x86/traps: honor EXT bit in error codes

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

> From: Jan Beulich
> Sent: Wednesday, November 11, 2015 5:23 PM
> 
> The specification does not explicitly limit the use of this bit to
> exceptions that can have selector style error codes, so to be on the
> safe side we should deal with it being set even on error codes formally
> documented to be always zero (if they're indeed always zero, the change
> is simply dead code in those cases).
> 
> Introduce and use (where suitable) X86_XEC_* constants to make the code
> easier to read.
> 
> To match the placement of the "hardware_trap" label, the "hardware_gp"
> one gets moved slightly too.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> v2: Drop #MC related changes. Simplify initial condition added to
>     do_trap(). Adjust a comment in do_general_protection().
> 

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel