Re: [Xen-devel] [PATCHv6] 04/28] build: convert HAS_PASSTHROUGH use to Kconfig

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.12.15 at 01:36, <cardoe@xxxxxxxxxx> wrote:
> On 11/30/15 8:50 AM, Jan Beulich wrote:
>>>>> On 24.11.15 at 18:51, <cardoe@xxxxxxxxxx> wrote:
>>> @@ -348,9 +348,9 @@ static XSM_INLINE int 
>>> xsm_deassign_device(XSM_DEFAULT_ARG struct domain *d, uint
>>>      return xsm_default_action(action, current->domain, d);
>>>  }
>>>  
>>> -#endif /* HAS_PASSTHROUGH && HAS_PCI */
>>> +#endif /* CONFIG_HAS_PASSTHROUGH && HAS_PCI */
>> 
>> I don't think fiddling with trailing comments like this one is really
>> useful - the connection is clear also without CONFIG_ prefix.
> 
> Most of this series was mechanical early on (e.g. sed). I can
> selectively undo updating the comments if that's desirable.

While I agree this makes it more work for you, it would certainly
ease review (simply by shrinking the amount of changes to look
at).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel