Re: [Xen-devel] [PATCH v3] Set {ident}_suite runvar when install a Debian guest.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH v3] Set {ident}_suite runvar when install a 
Debian guest."):
> On Tue, 2015-11-24 at 11:17 +0000, Ian Jackson wrote:
> > If you do this instead
> >   +    $gho->{Suite} //= guest_var($gho,'suite',undef);
> > the previous line (`return ... if') is not needed.
> 
> Done. (I suppose this will elide the call to guest_var if ->{Suite} is
> already defined, like an || would).

Indeed.  // is like || but looks at definedness rather than
trueishness.

> > > +    if ( ! $gho->{Suite} ) {
> > 
> > This is stylistically odd IMO.  Seems to have been written by a
> > hypervisor maintainer :-).
> 
> I think you are referring to the too many spaces and would normally do
>       if (!$gho->{Suite}) {
> or was there something else?

Yes, just that.

(Also saw your other mail, thanks.)

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel