Re: [Xen-devel] [PATCH v3] Set {ident}_suite runvar when install a Debian guest.

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Tue, 2015-11-24 at 12:41 +0000, Ian Campbell wrote:
> On Tue, 2015-11-24 at 11:17 +0000, Ian Jackson wrote:
> > Ian Campbell writes ("[PATCH v3] Set {ident}_suite runvar when install
> > a
> > Debian guest."):
> > > Currently those places which want this open code a lookup of the
> > > {ident}_suite runvar with a fallback to the configuration file.
> > > 
> > > However selecthost was missing such a lookup in the case where it is
> > > constructing a nested L1 host (which begins from the selectguest
> > > template), which lead to ts-xen-install on Jessie missing the
> > > installation of libnl-route-3-200.
> > > 
> > > Fix this by providing debian_guest_suite($gho) which as well as
> > > initialising $gho->{Suite} stores an {ident}_suite runvar (taking
> > > care
> > > to handle the case where one is already set by e.g. make-flight). For
> > > convenience debian_guest_suite() also returns the suite name.
> > > 
> > > ts-debian-install, ts-debian-di-install and ts-debian-hvm-install now
> > > use debian_guest_suite instead of open coding the lookup.
> > > 
> > > The final piece of the puzzle is to have selectguest() pickup the
> > > {ident}_suite runvar (if it is set) and initialise $gho->{Suite} from
> > > it.
> > 
> > Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > 
> > > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > > ---
> > > I've kicked off an adhoc run testing:
> > > +ÂÂÂÂtest-amd64-amd64-qemuu-nested);; # nested
> > > +ÂÂÂÂtest-amd64-amd64-xl-qemuu-debianhvm-amd64);; # regular HVM
> > > +ÂÂÂÂtest-amd64-amd64-xl-qcow2);; # DI install
> > > +ÂÂÂÂtest-amd64-amd64-xl);; # Normal PV
> 
> FYI this last one failed, I'll investigate and no doubt there will be a v4.
> I'll fix the style stuff as I go.

This turned out to be a missing "use Osstest::Debian" in ts-debian-install, 
so I shall retain the ack. I'll run another test before sending v4.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel