[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 4/4] xen/arm: p2m: Remove translation table when it's empty
On Mon, 2015-11-30 at 14:26 +0000, Julien Grall wrote: > + > > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂp2m->stats.mappings[level - 1]--; > > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂupdate_reference_mapping(pages[level - 1], > > > old_entry, *entry); > > > + > > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ/* > > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ* We can't free the page now because it may be > > > present > > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ* in the guest TLB. Queue it and free it after the > > > TLB > > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ* has been flushed. > > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ*/ > > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂpage_list_add(pg, &free_pages); > > > > You could have used page_list_move instead of del+add, but I can't > > quite > > convince myself it matters. > > Are you sure? No. > AFAICT, page_list_move move the head of the list from one > variable to another. So all the list is moved. I think you are probably right. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |