[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [PATCH 1/4] xen/arm: p2m: Flush for every exit paths in apply_p2m_changes
Currently, the TLB is not flushed if an error occured while updating the stage-2 p2m. However, the TLB will contain stall mappings for any entry updated so far. To avoid a such situation, flush on every exit paths when the variable "flush" is set. Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx> --- xen/arch/arm/p2m.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index e396c40..f910cab 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -1010,7 +1010,7 @@ static int apply_p2m_changes(struct domain *d, if ( (egfn - sgfn) > progress && !(progress & mask) ) { rc = progress; - goto tlbflush; + goto out; } break; } @@ -1096,15 +1096,13 @@ static int apply_p2m_changes(struct domain *d, rc = 0; -tlbflush: +out: if ( flush ) { flush_tlb_domain(d); iommu_iotlb_flush(d, sgfn, egfn - sgfn); } -out: - if ( rc < 0 && ( op == INSERT || op == ALLOCATE ) && addr != start_gpaddr ) { -- 2.1.4 _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |