Re: [Xen-devel] [PATCH 2/2] x86/cpu: Move set_cpumask() calls into c_early_init()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.11.15 at 17:59, <andrew.cooper3@xxxxxxxxxx> wrote:
> Before c/s 44e24f8567 "x86: don't call generic_identify() redundantly", the
> commandline-provided masks would take effect in Xen's view of the features.
> 
> As the masks got applied after the query for features, the redundant call to
> generic_identify() would clobber the wrong feature information with the new,
> correct information.

I'm seriously wondering: Why would the un-adjusted feature
information be wrong for Xen's own use (and perhaps even Dom0's)?
I view it exactly the other way around: Said commit actually fixed
this misbehavior.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel