Re: [Xen-devel] [PATCH 1/2] x86/cpu: Introduce cpu_dev.c_early_init()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.11.15 at 17:58, <andrew.cooper3@xxxxxxxxxx> wrote:
> The name is chosen to be consistent with Linux.  Doing this allows
> early_intel_workaround() to be removed from common code.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
with one adjustment suggestion (which I'll do on commit unless you
object):

> --- a/xen/arch/x86/cpu/intel.c
> +++ b/xen/arch/x86/cpu/intel.c
> @@ -156,10 +156,8 @@ static void __devinit set_cpuidmask(const struct 
> cpuinfo_x86 *c)
>       }
>  }
>  
> -void __devinit early_intel_workaround(struct cpuinfo_x86 *c)
> +static void __devinit early_init_intel(struct cpuinfo_x86 *c)

The __devinit should be dropped here considering that we mean
to drop them gradually anyway.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel