[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v4 2/7] xen/arm: introduce HYPERVISOR_platform_op on arm and arm64
On Fri, 2015-11-20 at 11:58 +0000, Stefano Stabellini wrote: > On Mon, 16 Nov 2015, Ian Campbell wrote: > > On Fri, 2015-11-13 at 18:10 +0000, Stefano Stabellini wrote: > > > > > > I agree with your point (I thought about it myself) but the current > > > assembly scheme for hypercalls doesn't work well with that. I would > > > have > > > to introduce, and maintain going forward, two special hypercall > > > implementations in assembly, one for arm and another for arm64, just > > > to > > > set interface_version. I don't think it is worth it; I prefer to have > > > to > > > maintain the explicit interface_version setting at the call sites > > > (that > > > today is just one). > > > > You could give the bare assembly stub a different name (append _core or > > _raw or something) and make HYPERVISOR_platform_op a C wrapper for it > > which > > DTRT. > > I had an idea. I just need to > > #define HYPERVISOR_platform_op_raw HYPERVISOR_platform_op The need for this #define is a bit unfortunate, but the alternatives (e.g. a suffix argument to the HYPERCALL*() macros or a RAWHYPERCALL variant) would seem to suck more, so I say go for it. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |