Re: [Xen-devel] [OSSTEST PATCH 09/22] LVM: Break out lv_create

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [OSSTEST PATCH 09/22] LVM: Break out lv_create"):
> On Wed, 2015-11-11 at 16:30 +0000, Ian Jackson wrote:
> >  There is a minor functional change: $gho->{Lvdev} has been put through
> >  lv_dev_mapper.  But we don't care about that in lv_create (since the
> >  LVM operations, and dd, are perfectly happy to use the `real',
> >  non-/dev/mapper, names).  So we can just use /dev/$vg/$lv.
> 
> That looks good. The "return $lvdev" from this new function would slightly
> encourage using this path in other situations which are not lv* commands
> and which might want the mapper version. I think this is a remote enough
> possibility to not worry about, although maybe you want to add a comment.

Yes, I guess, although if it breaks it will be obvious.  I don't think
I'll add a comment on that; it's obvious enough and the comment would
be clutter.

> In any case:
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel