[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [OSSTEST PATCH 09/22] LVM: Break out lv_create
Ian Campbell writes ("Re: [OSSTEST PATCH 09/22] LVM: Break out lv_create"): > On Tue, 2015-11-10 at 19:53 +0000, Ian Jackson wrote: > > +sub lv_create ($$$$) { > > + my ($ho, $vg, $lv, $mb) = @_; > > + my $lvdev = "/dev/$vg/$lv"; > > In the original code it was using $gho->{Lvdev}, is this semantic change > deliberate or a rebase-o? If the former then I think it warrants a comment > in the commit message. It was deliberate. I have added this to the commit message: lv_create doesn't (want to) take a $gho, but the $vg and $lv names directly (so that callers can use it when they don't have a suitable $gho whose $gho->{Lvdev} they want to use). In the one existing call site we pass $gho->{Vg} and $gho->{Lv} so that the effect is the same. There is a minor functional change: $gho->{Lvdev} has been put through lv_dev_mapper. But we don't care about that in lv_create (since the LVM operations, and dd, are perfectly happy to use the `real', non-/dev/mapper, names). So we can just use /dev/$vg/$lv. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |