[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] xl: don't print out uninitialised rc
On Wed, 2015-11-04 at 11:15 +0000, Wei Liu wrote: > In 5b725e56 (xl: improve return and exit codes of vcpu related > functions), the return value of libxl_cpu_bitmap_alloc was not stored in > rc anymore. Yet the subsequent fprintf still used that. > > While it is trivial to reinstate the original implementation, xl's > caller has no idea what a libxl error code is so printing out rc won't > be that useful. I don't buy this I'm afraid. xl prints the libxl error code in lots of places and it is indeed useful for a person (e.g. a developer reading a bug report) since they can go and look the number up. I'm not sure where "xl's caller" comes into it, since this is only about printing and not returning. > Don't print out rc in that case. > > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx> > --- > Cc: Ian Campbell <ian.campbell@xxxxxxxxxx> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> > Cc: Dario Faggioli <dario.faggioli@xxxxxxxxxx> > Cc: Harmandeep Kaur <write.harmandeep@xxxxxxxxx> > --- > Âtools/libxl/xl_cmdimpl.c | 2 +- > Â1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c > index 2756d2f..6056344 100644 > --- a/tools/libxl/xl_cmdimpl.c > +++ b/tools/libxl/xl_cmdimpl.c > @@ -5474,7 +5474,7 @@ static int vcpuset(uint32_t domid, const char* > nr_vcpus, int check_host) > ÂÂÂÂÂÂÂÂÂÂÂÂÂreturn 1; > ÂÂÂÂÂ} > ÂÂÂÂÂif (libxl_cpu_bitmap_alloc(ctx, &cpumap, max_vcpus)) { > -ÂÂÂÂÂÂÂÂfprintf(stderr, "libxl_cpu_bitmap_alloc failed, rc: %d\n", rc); > +ÂÂÂÂÂÂÂÂfprintf(stderr, "libxl_cpu_bitmap_alloc failed\n"); > ÂÂÂÂÂÂÂÂÂreturn 1; > ÂÂÂÂÂ} > ÂÂÂÂÂfor (i = 0; i < max_vcpus; i++) _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |