[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [PATCH] xl: don't print out uninitialised rc
In 5b725e56 (xl: improve return and exit codes of vcpu related functions), the return value of libxl_cpu_bitmap_alloc was not stored in rc anymore. Yet the subsequent fprintf still used that. While it is trivial to reinstate the original implementation, xl's caller has no idea what a libxl error code is so printing out rc won't be that useful. Don't print out rc in that case. Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx> --- Cc: Ian Campbell <ian.campbell@xxxxxxxxxx> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Cc: Dario Faggioli <dario.faggioli@xxxxxxxxxx> Cc: Harmandeep Kaur <write.harmandeep@xxxxxxxxx> --- tools/libxl/xl_cmdimpl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 2756d2f..6056344 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -5474,7 +5474,7 @@ static int vcpuset(uint32_t domid, const char* nr_vcpus, int check_host) return 1; } if (libxl_cpu_bitmap_alloc(ctx, &cpumap, max_vcpus)) { - fprintf(stderr, "libxl_cpu_bitmap_alloc failed, rc: %d\n", rc); + fprintf(stderr, "libxl_cpu_bitmap_alloc failed\n"); return 1; } for (i = 0; i < max_vcpus; i++) -- 2.1.4 _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |