[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v3 1/6] xen: sched: fix locking of remove_vcpu() in credit1
On Mon, 2015-11-02 at 18:04 +0000, George Dunlap wrote: > On 29/10/15 23:04, Dario Faggioli wrote: > > @@ -936,15 +936,19 @@ csched_vcpu_remove(const struct scheduler > > *ops, struct vcpu *vc) > > vcpu_unpause(svc->vcpu); > > } > > > > + lock = vcpu_schedule_lock_irq(vc); > > + > > if ( __vcpu_on_runq(svc) ) > > __runq_remove(svc); > > > > - spin_lock_irqsave(&(prv->lock), flags); > > + vcpu_schedule_unlock_irq(lock, vc); > > Actually, at this point the domain should be either paused or in the > middle of being destroyed, so it shouldn't be possible for the vcpu > to > be on the runqueue, should it? > Makes sense. > Should we instead change that if() to an > ASSERT(!__vcpu_on_runqueue(svc))? > I like the idea, I'll do it like this. Thanks and Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) Attachment:
signature.asc _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |