[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v2] xl: log an error if libxl_cpupool_destroy() fails
On Tue, 2015-11-03 at 17:08 +0000, Ian Campbell wrote: > On Wed, 2015-10-28 at 16:51 +0000, Wei Liu wrote: > > On Wed, Oct 28, 2015 at 05:43:51PM +0100, Dario Faggioli wrote: > > > In fact, right now, failing at destroying a cpupool is just > > > not reported to the user in any explicit way. > > > > > > Let's log an error, as it is customary for xl in these cases. > > > > > > Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx> > > > Reviewed-by: Juergen Gross <jgross@xxxxxxxx> > > > > Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx> > > This conflicted with the changes to use EXIT_(ERROR|SUCCESS). By > changing > "return 0" into "return EXIT_SUCCESS" and "return 1" into "return > EXIT_ERROR" in the context it applied cleanly. > Right, thanks for trying. > I was about to apply when I noticed the strange Reviewed-by: Jueregen > (having already spotted and fixed in the Cc). I don't think I want to > apply > it like that. > Oh, come on! How the heck did I manage to put it in there like that, and to not notice it until now! :-( Anyway, sorry for wasting your time. > Please can you fix and rebase (after I push Harman's changes > soon) and resend. > Sure thing. Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) Attachment:
signature.asc _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |