Re: [Xen-devel] [PATCH OSSTEST 8/8] Debian: Use dtbs from kernel dist when booting that kernel

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH OSSTEST 8/8] Debian: Use dtbs from kernel dist 
when booting that kernel"):
> The kernel dist built by ts-kernel-build puts the corresponding dtbs
> into /boot/dtbs/$kvers.
> 
> The host installers dtbs remain in /boot/dtbs and are used when
                    ^
Missing apostrophe "installer's".

> It's possible that this change will expose bugs which exist in the
> DTBs in previous kernel branches (3.18 and 4.1). I've not
> investigated, I think we should accept this possibility and deal with
> it via backport requests (and maybe some force pushes if appropriate)
> as necessary.

OK.

> -sub uboot_scr_load_dtb () {
> +sub uboot_scr_load_dtb (;$) {

Some of the information about host installer dtbs being in /boot
etc. (particularly that from "ts-kernel-build: Include dtbs in dist
file"'s commit message) might benefit from being in a comment here.

Anyway, all of this is (like my other comments) cosmetic and minor,
so:

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel