Re: [Xen-devel] [PATCH v5 08/22] xen/arm: ITS: Add virtual ITS commands support

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 31/07/15 07:57, Vijay Kilari wrote:
>>>  /*
>>>   * Local variables:
>>>   * mode: C
>>> diff --git a/xen/include/asm-arm/gic-its.h b/xen/include/asm-arm/gic-its.h
>>> index 66be53a..cdb786c 100644
>>> --- a/xen/include/asm-arm/gic-its.h
>>> +++ b/xen/include/asm-arm/gic-its.h
>>> @@ -21,6 +21,8 @@
>>>  #include <asm/gic_v3_defs.h>
>>>  #include <xen/rbtree.h>
>>>
>>> +#define MASK_4K                         0xfffffffff000UL
>>
>> If you name the macro MASK_4K this should go in xen/sizes.h and not in
>> the gic-its.h. Although on v4 [1], Ian suggested to rename into
>> GITS_CBASER_PA_MASK which IHMO would be better.
> 
> 
>  This is used by other generic code as well in later patches.
> One option is to introduce separate macro for each usage or generic name like
> GITS_PA_MASK

IHMO a mask per register would be better.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel