Re: [Xen-devel] [PATCH v2 for-4.6 2/3] xen: replace non-POSIX error codes

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 07/22/2015 12:07 PM, Roger Pau Monne wrote:
> Some DOMCTLs returned non-POSIX error codes, replace them with POSIX
> compilant values instead. EBADRQC and EBADSLT are replaced by EDOM, while
> EUSERS is replaced with EOVERFLOW.
> 
> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> Changes since v1:
>  - Use EDOM instead of EINVAL.
> ---
> Nothing in libxc or libxl seems to check for those specific error codes, so
> I guess it's fine to replace them with whatever we want.
> ---
>  xen/arch/x86/mm/paging.c | 2 +-
>  xen/common/domain.c      | 4 ++--
>  xen/common/hvm/save.c    | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/arch/x86/mm/paging.c b/xen/arch/x86/mm/paging.c
> index 7089155..9bd54a8 100644
> --- a/xen/arch/x86/mm/paging.c
> +++ b/xen/arch/x86/mm/paging.c
> @@ -766,7 +766,7 @@ long 
> paging_domctl_continuation(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
>  
>      if ( op.interface_version != XEN_DOMCTL_INTERFACE_VERSION ||
>           op.cmd != XEN_DOMCTL_shadow_op )
> -        return -EBADRQC;
> +        return -EDOM;

mm bit:

Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Since this is internal, this isn't even a bike shed -- it's debating the
color of the insulation on the pipes in the basement.  Feel free to
retain this Ack even if you end up changing this particular errno to
something else again.

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel