Re: [Xen-devel] [PATCH v2 0/15+5+5] Begin to disentangle libxenctrl and provide some stable libraries

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-07-15 at 16:53 +0100, Andrew Cooper wrote:
> 
> > I'm stilling mulling over putting everything into tools/libs/FOO
> > instead of tools/libxenFOO
> 
> On balance, +1.  tools/ is already quite a mixed bag of stuff.

OK, I think I'm going to go ahead with this.

> > , I still haven't but I could if people think
> > it is worthwhile. Eventually I'd like to split libxc into 
> > libxenguest
> > and libxenctrl to cut down on the amount of strange cross talk...
> 
> Very much +1.

OK (eventually ;-))

> FWIW, also splitting xl and libxl into different directories.

Yes, good idea (also "eventually ;-)").

While I'm accumulating TODO items in this thread, every library which
gets split out needs a careful review before it should be declared
A[PBI] stable. I'm thinking at least:

      * Consistent error handling (return -1 + setting errno=EFOO)
      * Correct types
      * Const correctness
      * General interface sanity check

Anything else?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel