Re: [Xen-devel] [v11][PATCH 11/16] tools/libxl: detect and avoid conflicts with RDM

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.07.15 at 03:30, <tiejun.chen@xxxxxxxxx> wrote:
> CC: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> CC: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> CC: Ian Campbell <ian.campbell@xxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Signed-off-by: Tiejun Chen <tiejun.chen@xxxxxxxxx>
> Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
> ---
> v11:
> 
> * Use GCNEW_ARRAY to replace libxl__malloc()
> 
> * #define pfn_to_paddrk is missing safety () around x, and
>   move this into libxl_internal.h
> 
> * Rename set_rdm_entries() to add_rdm_entry() and put the
>   increment at the end so that the assignments are
>   to ->rdms[d_config->num_rdms].
> 
> * "Simply make it so that if there are any rdms specified
>   in the domain config, they are used instead of the
>   automatically gathered information (from strategy and
>   devices)." So just return if d_config->rmds is valid.
> 
> * Shorten some code comments.

I think it is not the first time that we're pointing out to you that
when you make not just cosmetic changes, review and ack tags
should be dropped.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel