Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 13/25] migration/save: pass checkpointed_stream from libxl to libxc

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, Jul 17, 2015 at 12:21:11AM +0800, Yang Hongyang wrote:
[...]
> >>>Do (or will) specific non-zero values have any meaning to the libxc
> >>>layer? i.e. does it have any knowledge of COLO vs. Remus as the libxl
> >>>enum added in the last patch does?
> >>
> >>Yes, libxc side should be aware of the type of checkpointed_stream (Remus
> >>or COLO).
> >>
> >>I think it is better to document the non-zero values here?
> >>for example:
> >>      * @parm checkpointed_stream non-zero if the far end of the stream is 
> >> using
> >>      *                           checkpointing
> >>      *                           0 no checkpointed stream
> >>      *                           1 Remus
> >>      *                           2 COLO
> >>
> >
> >These should be proper #defines instead of being buried in comments --
> >so that you can use them in code.
> 
> Those defines are introduced later in the colo series, I will move them
> here and follow Ian C's suggestion using XC_ prefix, or I can move this
> patch down to colo series.
> 

Either works for me.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel