Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 13/25] migration/save: pass checkpointed_stream from libxl to libxc

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Jul 15, 2015 at 03:45:39PM +0800, Yang Hongyang wrote:
> Pass checkpointed_stream from libxl to libxc.
> It won't affact legacy migration because legacy migration
> won't use this param.
> 
> Signed-off-by: Yang Hongyang <yanghy@xxxxxxxxxxxxxx>
> CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> CC: Wei Liu <wei.liu2@xxxxxxxxxx>
> CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
[...]
>  
> +    if (dss->checkpointed_stream && !r_info) {

Please explicitly check for _NONE type instead of relying it of being 0.
Arguably the actual value is not going to change in the future but it's
better to be explicit.

Wei.

> +        LOG(ERROR, "Migration stream is checkpointed, but there's no "
> +                   "checkpoint info!");
> +        goto out;
> +    }
> +
>      dss->rc = 0;
>      logdirty_init(&dss->logdirty);
>      dsps->ao = ao;

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel