Re: [Xen-devel] [PATCH v4 --for 4.6 COLOPre 21/25] tools/libxl: rename remus device to checkpoint device

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-07-16 at 17:23 +0800, Yang Hongyang wrote:
> 
> On 07/15/2015 09:32 PM, Ian Campbell wrote:
> > On Wed, 2015-07-15 at 15:45 +0800, Yang Hongyang wrote:
> >>   tools/libxl/libxl_types.idl           |   4 +-
> >
> >> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> >> index e8d3647..1d676ef 100644
> >> --- a/tools/libxl/libxl_types.idl
> >> +++ b/tools/libxl/libxl_types.idl
> >> @@ -61,8 +61,8 @@ libxl_error = Enumeration("error", [
> >>       (-15, "LOCK_FAIL"),
> >>       (-16, "JSON_CONFIG_EMPTY"),
> >>       (-17, "DEVICE_EXISTS"),
> >> -    (-18, "REMUS_DEVOPS_DOES_NOT_MATCH"),
> >> -    (-19, "REMUS_DEVICE_NOT_SUPPORTED"),
> >> +    (-18, "CHECKPOINT_DEVOPS_DOES_NOT_MATCH"),
> >> +    (-19, "CHECKPOINT_DEVICE_NOT_SUPPORTED"),
> >>       (-20, "VNUMA_CONFIG_INVALID"),
> >>       (-21, "DOMAIN_NOTFOUND"),
> >>       (-22, "ABORTED"),
> >
> > This is an API change, which I think we discussed before.
> >
> > In <558BC6EE.60801@xxxxxxxxxxxxxx> you said you would add an extra patch
> > to deal with that, and I think that needs to come before this automatic
> > renaming so that there is no bisect hazard.
> 
> Seems either before or after will break the bisection...Only merge in one
> patch will makes sense...

If you break out this specific renaming into a precursor patch then you
can add the compat stuff in at that time. Please don't combine all that
into this one patch.

> I don't see any such patch
> > even after this point though (from grepping your colo-v8 branch).
> >
> > Ian.
> >
> > .
> >
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel