Re: [Xen-devel] Regression in OSSTest Windows install test case

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Wei Liu [mailto:wei.liu2@xxxxxxxxxx]
> Sent: 15 July 2015 15:46
> To: Andrew Cooper
> Cc: Wei Liu; xen-devel@xxxxxxxxxxxxxxxxxxxx; Jan Beulich; Paul Durrant
> Subject: Re: Regression in OSSTest Windows install test case
> 
> On Wed, Jul 15, 2015 at 03:43:09PM +0100, Andrew Cooper wrote:
> > On 15/07/15 15:40, Wei Liu wrote:
> > > Hi all
> > >
> > > The Windows install test case has been failing reliably in OSSTest for
> > > the last 6 runs.
> > >
> > > The issue manifest as Windows hit blue screen with garbled text that
> > > cannot be recognised when booting. Xen doesn't complain about any
> > > failures.
> > >
> > > I bisected that and found this commit is to be blamed.
> > >
> > > commit 3bbaaec09b1b942f5624dee176da6e416d31f982
> > > Author: Paul Durrant <paul.durrant@xxxxxxxxxx>
> > > Date:   Thu Jul 9 19:04:00 2015 +0200
> > >
> > >     x86/hvm: unify stdvga mmio intercept with standard mmio intercept
> > >
> > >     It's clear from the following check in hvmemul_rep_movs:
> > >
> > >         if ( sp2mt == p2m_mmio_direct || dp2mt == p2m_mmio_direct ||
> > >              (sp2mt == p2m_mmio_dm && dp2mt == p2m_mmio_dm) )
> > >             return X86EMUL_UNHANDLEABLE;
> > >
> > >     that mmio <-> mmio copy is not handled. This means the code in the
> > >     stdvga mmio intercept that explicitly handles mmio <-> mmio copy
> when
> > >     hvm_copy_to/from_guest_phys() fails is never going to be executed.
> > >
> > >     This patch therefore adds a check in hvmemul_do_io_addr() to make
> sure
> > >     mmio <-> mmio is disallowed and then registers standard mmio
> intercept ops
> > >     in stdvga_init().
> > >
> > >     With this patch all mmio and portio handled within Xen now goes
> through
> > >     process_io_intercept().
> > >
> > >     Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> > >     Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > >
> > > Tell me if you need more information or want me to test a patch. I do
> > > have test environment at hand.
> >
> > Given the nature of the patch, I would not be unduly surprised that the
> > text is garbled.
> >
> > Which windows and qemu are you using?  We have not encountered a
> single
> > failure like this in XenServer testing.
> >
> 
> win7-x64.iso from OSSTest.
> 
> QEMU emulator version 2.2.1, Copyright (c) 2003-2008 Fabrice Bellard
> 

Ok, could be a bad interaction with upstream QEMU then. I'll try to repro. Most 
of my dev testing was done with win7 32 bit and upstream QEMU though.

  Paul

> 
> > ~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel