[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Regression in OSSTest Windows install test case



Hi all

The Windows install test case has been failing reliably in OSSTest for
the last 6 runs.

The issue manifest as Windows hit blue screen with garbled text that
cannot be recognised when booting. Xen doesn't complain about any
failures.

I bisected that and found this commit is to be blamed.

commit 3bbaaec09b1b942f5624dee176da6e416d31f982
Author: Paul Durrant <paul.durrant@xxxxxxxxxx>
Date:   Thu Jul 9 19:04:00 2015 +0200

    x86/hvm: unify stdvga mmio intercept with standard mmio intercept
    
    It's clear from the following check in hvmemul_rep_movs:
    
        if ( sp2mt == p2m_mmio_direct || dp2mt == p2m_mmio_direct ||
             (sp2mt == p2m_mmio_dm && dp2mt == p2m_mmio_dm) )
            return X86EMUL_UNHANDLEABLE;
    
    that mmio <-> mmio copy is not handled. This means the code in the
    stdvga mmio intercept that explicitly handles mmio <-> mmio copy when
    hvm_copy_to/from_guest_phys() fails is never going to be executed.
    
    This patch therefore adds a check in hvmemul_do_io_addr() to make sure
    mmio <-> mmio is disallowed and then registers standard mmio intercept ops
    in stdvga_init().
    
    With this patch all mmio and portio handled within Xen now goes through
    process_io_intercept().
    
    Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
    Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Tell me if you need more information or want me to test a patch. I do
have test environment at hand.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.