Re: [Xen-devel] [RFC v3] xSplice design

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Mon, Jul 06, 2015 at 04:26:56PM -0400, Konrad Rzeszutek Wilk wrote:
> Since RFC v2 
> [http://lists.xen.org/archives/html/xen-devel/2015-05/msg02142.html]
>  - Ingested every review comment in.
> 
> For those who prefer an diff of what changed between v2 and this
> I am attaching an diff to help easy reviewing.

I made a bit of mess with the #define. Attached is a diff against
this file which fixes some of the numbering issues.

diff --git a/docs/misc/xsplice.markdown b/docs/misc/xsplice.markdown
index 29cd238..576debd 100644
--- a/docs/misc/xsplice.markdown
+++ b/docs/misc/xsplice.markdown
@@ -747,11 +747,11 @@ The `summary` structure contains an summary of payload 
which includes:
 
  * `id` the unique id.
  * `status` - whether it has been:
- 1. *XSPLICE_STATUS_LOADED* (0) has been loaded.
- 2. *XSPLICE_STATUS_PROGRESS* (1) acting on the **XEN_SYSCTL_XSPLICE_ACTION** 
command.
- 3. *XSPLICE_STATUS_CHECKED*  (2) the ELF payload safety checks passed.
- 4. *XSPLICE_STATUS_APPLIED* (3) loaded, checked, and applied.
- 5. *XSPLICE_STATUS_REVERTED* (4) loaded, checked, applied and then also 
reverted.
+ 1. *XSPLICE_STATUS_LOADED* (1) has been loaded.
+ 2. *XSPLICE_STATUS_PROGRESS* (2) acting on the **XEN_SYSCTL_XSPLICE_ACTION** 
command.
+ 3. *XSPLICE_STATUS_CHECKED*  (3) the ELF payload safety checks passed.
+ 4. *XSPLICE_STATUS_APPLIED* (4) loaded, checked, and applied.
+ 5. *XSPLICE_STATUS_REVERTED* (5) loaded, checked, applied and then also 
reverted.
  6. Negative values is an error. The error would be of EXX format.
 
 The return value is zero on success and EXX on failure. This operation
@@ -760,11 +760,11 @@ is synchronous and does not require preemption.
 The structure is as follow:
 
 <pre>
-#define XSPLICE_STATUS_LOADED    0  
-#define XSPLICE_STATUS_PROGRESS  1  
-#define XSPLICE_STATUS_CHECKED   2  
-#define XSPLICE_STATUS_APPLIED   3  
-#define XSPLICE_STATUS_REVERTED  4  
+#define XSPLICE_STATUS_LOADED    1  
+#define XSPLICE_STATUS_PROGRESS  2  
+#define XSPLICE_STATUS_CHECKED   3  
+#define XSPLICE_STATUS_APPLIED   4  
+#define XSPLICE_STATUS_REVERTED  5  
 
 struct xen_sysctl_xsplice_summary {  
     char id[40];  /* IN/OUT, name of the patch. */  
@@ -805,11 +805,11 @@ The `summary` structure contains an summary of payload 
which includes:
  * `version` version of the data.
  * `id` unique id.
  * `status` - whether it has been:
- 1. *XSPLICE_STATUS_LOADED* (0) has been loaded.
- 2. *XSPLICE_STATUS_PROGRESS* (1) acting on the **XEN_SYSCTL_XSPLICE_ACTION** 
command.
- 3. *XSPLICE_STATUS_CHECKED*  (2) the ELF payload safety checks passed.
- 4. *XSPLICE_STATUS_APPLIED* (3) loaded, checked, and applied.
- 5. *XSPLICE_STATUS_REVERTED* (4) loaded, checked, applied and then also 
reverted.
+ 1. *XSPLICE_STATUS_LOADED* (1) has been loaded.
+ 2. *XSPLICE_STATUS_PROGRESS* (2) acting on the **XEN_SYSCTL_XSPLICE_ACTION** 
command.
+ 3. *XSPLICE_STATUS_CHECKED*  (3) the ELF payload safety checks passed.
+ 4. *XSPLICE_STATUS_APPLIED* (4) loaded, checked, and applied.
+ 5. *XSPLICE_STATUS_REVERTED* (5) loaded, checked, applied and then also 
reverted.
  6. Any negative values means there has been error. The value is in EXX format.
 
 The structure is as follow:
@@ -867,7 +867,6 @@ The return value will be zero unless the provided fields 
are incorrect.
 The structure is as follow:
 
 <pre>
-#define XSPLICE_ACTION_LOADED 0  
 #define XSPLICE_ACTION_CHECK  1  
 #define XSPLICE_ACTION_UNLOAD 2  
 #define XSPLICE_ACTION_REVERT 3  

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel