Re: [Xen-devel] [PATCH v3 for Xen 4.6 4/4] xl: enable per-VCPU parameter settings for RTDS scheduler

[Chong Li <lichong659@xxxxxxxxx>]

On Tue, Jul 7, 2015 at 10:34 AM, Dario Faggioli
<dario.faggioli@xxxxxxxxxx> wrote:
> On Sun, 2015-06-28 at 21:44 -0500, Chong Li wrote:
>> Change main_sched_rtds and related output functions to support per-VCPU 
>> settings.
>>
>> Changes on PATCH v2:
>>
>> 1) Remove per-domain output functions for RTDS scheduler.
>>
>> 2) Users now use '-v all' to specify all VCPUs.
>>
>> 3) Support outputting a subset of the parameters of the VCPUs of a specific 
>> domain.
>>
>> 4) When setting all VCPUs with the same parameters (by only one command), no 
>> per-domain function is invoked.
>>
>> Signed-off-by: Chong Li <chong.li@xxxxxxxxx>
>> Signed-off-by: Meng Xu <mengxu@xxxxxxxxxxxxx>
>> Signed-off-by: Sisu Xi <xisisu@xxxxxxxxx>
>>
> I think this patch is fine. I've asked already, when replying to the
> cover message, what happens if one uses just:
>
>  # xl sched-rtds
>
> or
>
> # xl sched-rtds -d vm1
>
> and it looks to me that, instead of getting rid of
> sched_rtds_domain_output(), you can leave it there and make it respond
> to the above calls, with the effect of returning the default values, as
> agreed and implemented.

I agree. I'll do that in the next version.

Chong

>
> Dario
> --
> <<This happens because I choose it to happen!>> (Raistlin Majere)
> -----------------------------------------------------------------
> Dario Faggioli, Ph.D, http://about.me/dario.faggioli
> Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)



-- 
Chong Li
Department of Computer Science and Engineering
Washington University in St.louis

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel