Re: [Xen-devel] [PATCH v12 3/8] tools: Add vmware_hwver support

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-07-01 at 16:14 -0400, Konrad Rzeszutek Wilk wrote:
> On Sat, Jun 27, 2015 at 07:27:40PM -0400, Don Slutz wrote:
> > From: Don Slutz <dslutz@xxxxxxxxxxx>
> > 
> > This is used to set xen_arch_domainconfig vmware_hw. It is set to
> > the emulated VMware virtual hardware version.
> > 
> > Currently 0, 3-4, 6-11 are good values.  However the code only
> > checks for == 0, != 0, or < 7.
> > 
> > Signed-off-by: Don Slutz <dslutz@xxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> > 
> >  docs/man/xl.cfg.pod.5       | 17 +++++++++++++++++
> >  tools/libxl/libxl_create.c  |  4 +++-
> >  tools/libxl/libxl_types.idl |  1 +
> >  tools/libxl/libxl_x86.c     |  3 +--
> >  tools/libxl/xl_cmdimpl.c    |  2 ++
> >  5 files changed, 24 insertions(+), 3 deletions(-)
> > 
> > diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5
> > index 84078f6..4a01527 100644
> > --- a/docs/man/xl.cfg.pod.5
> > +++ b/docs/man/xl.cfg.pod.5
> > @@ -1348,6 +1348,23 @@ The viridian option can be specified as a boolean. A 
> > value of true (1)
> >  is equivalent to the list [ "defaults" ], and a value of false (0) is
> >  equivalent to an empty list.
> >  
> > +=item B<vmware_hwver=NUMBER>
> > +
> > +Turns on or off the exposure of VMware cpuid.  The number is
> > +VMware's hardware version number, where 0 is off.  A number >= 7
> > +is needed to enable exposure of VMware cpuid.
> > +
> > +The hardware version number (vmware_hwver) comes from VMware config files.
> > +
> > +=over 4
> > +
> > +In a .vmx it is virtualHW.version
> > +
> > +In a .ovf it is part of the value of vssd:VirtualSystemType.
> > +For vssd:VirtualSystemType == vmx-07, vmware_hwver = 7.
> > +
> > +=back
> > +
> 
> Perhaps add 'Recommended value is 7' ?

Assuming that is a good recommendation then that might be a good
enhancement for a future patch. Or perhaps some sort of simple mapping
from VMware product versions/names to a suitable value to use, unless
that means having to think about trademarks etc.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel