Re: [Xen-devel] [PATCH v12 7/8] Add IOREQ_TYPE_VMWARE_PORT

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

> >>diff --git a/xen/include/public/hvm/params.h 
> >>b/xen/include/public/hvm/params.h
> >>index 7c73089..130eba9 100644
> >>--- a/xen/include/public/hvm/params.h
> >>+++ b/xen/include/public/hvm/params.h
> >>@@ -50,6 +50,8 @@
> >>  #define HVM_PARAM_PAE_ENABLED  4
> >>  #define HVM_PARAM_IOREQ_PFN    5
> >>+/* Extra vmport PFN. */
> >s/Extra/optional/ ?
> 
> I do not think "optional" is good to use here.  This PFN is required for
> QEMU (or any other ioreq server) to handle vmport access.  If you have a
> better name then "extra", please let me know.

How about just 'VMWare Port PFN' ?
> 
>    -Don Slutz
> 
> >>+#define HVM_PARAM_VMPORT_REGS_PFN 35
> >>  #define HVM_PARAM_BUFIOREQ_PFN 6
> >>  #define HVM_PARAM_BUFIOREQ_EVTCHN 26
> >>@@ -187,6 +189,6 @@
> >>  /* Location of the VM Generation ID in guest physical address space. */
> >>  #define HVM_PARAM_VM_GENERATION_ID_ADDR 34
> >>-#define HVM_NR_PARAMS          35
> >>+#define HVM_NR_PARAMS          36
> >>  #endif /* __XEN_PUBLIC_HVM_PARAMS_H__ */
> >>-- 
> >>1.8.3.1
> >>
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel