Re: [Xen-devel] [PATCH v3] libxl: Add AHCI support for upstream qemu

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Fri, 2015-06-26 at 13:40 +0200, Fabio Fantoni wrote:
> diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> index 0a7913b..6b79ce9 100644
> --- a/tools/libxl/libxl.h
> +++ b/tools/libxl/libxl.h
> @@ -596,6 +596,16 @@ typedef struct libxl__ctx libxl_ctx;
>  #define LIBXL_HAVE_SPICE_STREAMINGVIDEO 1
>  
>  /*
> + * LIBXL_HAVE_AHCI

Can we call this LIBXL_HAVE_HVM_AHCI or something else to indicate it is
HVM specific please?

> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index c858068..30e5f50 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -2146,6 +2146,17 @@ skip_vfb:
>              b_info->u.hvm.vga.kind = l ? LIBXL_VGA_INTERFACE_TYPE_STD :
>                                           LIBXL_VGA_INTERFACE_TYPE_CIRRUS;
>  
> +        if (!xlu_cfg_get_string (config, "hdtype", &buf, 0)) {
> +            if (!strcmp(buf, "ide")) {
> +                b_info->u.hvm.hdtype = LIBXL_HDTYPE_IDE;
> +            } else if (!strcmp(buf, "ahci")) {
> +                b_info->u.hvm.hdtype = LIBXL_HDTYPE_AHCI;

Please use the libxl_hdtype_from_string which the IDL will have
autogenerated for you.

See the use of e.g. libxl_bios_type_from_string in this file for an
example.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel