[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3] libxl: Add AHCI support for upstream qemu

To: xen-devel@xxxxxxxxxxxxxxxxxxx
From: Fabio Fantoni <fabio.fantoni@xxxxxxx>
Date: Tue, 7 Jul 2015 10:04:29 +0200
Cc: wei.liu2@xxxxxxxxxx, Ian.Campbell@xxxxxxxxxx, Stefano.Stabellini@xxxxxxxxxxxxx, George.Dunlap@xxxxxxxxxxxxx, Ian.Jackson@xxxxxxxxxxxxx, Paul.Durrant@xxxxxxxxxx, anthony.perard@xxxxxxxxxx
Delivery-date: Tue, 07 Jul 2015 08:04:47 +0000
List-id: Xen developer discussion <xen-devel.lists.xen.org>

Il 26/06/2015 13:40, Fabio Fantoni ha scritto:

Usage:
hdtype=ide|ahci (default=ide)

If hdtype=ahci adds ich9 disk controller in ahci mode and uses it with
upstream qemu to emulate disks instead of ide.
It doesn't support cdroms which still using ide (cdroms will use
"-device ide-cd" as new qemu parameter)
Ahci requires new qemu parameter but for now other emulated disks cases
remains with old ones (I did it in other patch, not needed by this one)
I did it as libxl parameter disabled by default to avoid possible
problems:
- with save/restore/migration (restoring with ahci a domU that was with
ide instead)
- windows < 8 without pv drivers (a registry key change is needed for
AHCI<->IDE change FWIK to avoid possible blue screen)
- windows XP or older that many not support ahci by default.
Setting AHCI with libxl parameter and default to disabled seems the best
solution.
AHCI increase hvm domUs boot performance. On linux hvm domU I saw up to
only 20% of the previous total boot time, whereas boot time decrease a
lot on W7 domUs for most of boots I have done. Small difference in boot
time compared to ide mode on W8 and newer (probably other xen
improvements or fixes are needed not ahci related)

Signed-off-by: Fabio Fantoni <fabio.fantoni@xxxxxxx>

---

Changes in v3:
- changed ahci=0|1 to hdtype=ide|ahci
- small doc entry and code improvements as suggested by Ian Campbell


Ping...

Features freeze of xen 4.6 is near, can someone review this new versionplease?


Changes in v2:
- libxl_dm.c: small code style fix
- added vbd-interface.txt changes
---
  docs/man/xl.cfg.pod.5       | 10 ++++++++++
  docs/misc/vbd-interface.txt |  6 ++++--
  tools/libxl/libxl.h         | 10 ++++++++++
  tools/libxl/libxl_create.c  |  3 +++
  tools/libxl/libxl_dm.c      | 11 ++++++++++-
  tools/libxl/libxl_types.idl |  6 ++++++
  tools/libxl/xl_cmdimpl.c    | 11 +++++++++++
  7 files changed, 54 insertions(+), 3 deletions(-)

diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5
index a3e0e2e..ef7d558 100644
--- a/docs/man/xl.cfg.pod.5
+++ b/docs/man/xl.cfg.pod.5
@@ -904,6 +904,16 @@ default is B<cd>.

=back+=item B<hdtype="STRING">

+
+Select the hd disk type (ide|ahci).
+If hdtype=ahci adds ich9 disk controller in AHCI mode and uses it with
+upstream qemu to emulate disks instead of IDE. It decreases boot time
+but may not be supported by default in Windows xp and older Windows.
+The default is ide.
+
+=back
+
  =head3 Paging

The following options control the mechanisms used to virtualise guest

diff --git a/docs/misc/vbd-interface.txt b/docs/misc/vbd-interface.txt
index f873db0..1c996bf 100644
--- a/docs/misc/vbd-interface.txt
+++ b/docs/misc/vbd-interface.txt
@@ -3,18 +3,20 @@ Xen guest interface

A Xen guest can be provided with block devices. These are always

  provided as Xen VBDs; for HVM guests they may also be provided as
-emulated IDE or SCSI disks.
+emulated IDE, AHCI or SCSI disks.

The abstract interface involves specifying, for each block device:* Nominal disk type: Xen virtual disk (aka xvd*, the default); SCSI

-   (sd*); IDE (hd*).
+   (sd*); IDE or AHCI (hd*).

For HVM guests, each whole-disk hd* and and sd* device is made

     available _both_ via emulated IDE resp. SCSI controller, _and_ as a
     Xen VBD.  The HVM guest is entitled to assume that the IDE or SCSI
     disks available via the emulated IDE controller target the same
     underlying devices as the corresponding Xen VBD (ie, multipath).
+   In hd* case with hdtype=ahci, disk will be AHCI via emulated
+   ich9 disk controller.

For PV guests every device is made available to the guest only as a

     Xen VBD.  For these domains the type is advisory, for use by the
diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
index 0a7913b..6b79ce9 100644
--- a/tools/libxl/libxl.h
+++ b/tools/libxl/libxl.h
@@ -596,6 +596,16 @@ typedef struct libxl__ctx libxl_ctx;
  #define LIBXL_HAVE_SPICE_STREAMINGVIDEO 1

/*

+ * LIBXL_HAVE_AHCI
+ *
+ * If defined, then the u.hvm structure will contain a enum type:
+ * hdtype. This value defines if ahci support is present.
+ *
+ * If this is not defined, the ahci support is ignored.
+ */
+#define LIBXL_HAVE_AHCI 1
+
+/*
   * LIBXL_HAVE_DOMAIN_CREATE_RESTORE_PARAMS 1
   *
   * If this is defined, libxl_domain_create_restore()'s API has changed to
diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
index 86384d2..0ff7046 100644
--- a/tools/libxl/libxl_create.c
+++ b/tools/libxl/libxl_create.c
@@ -250,6 +250,9 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc,
          if (!b_info->u.hvm.vga.kind)
              b_info->u.hvm.vga.kind = LIBXL_VGA_INTERFACE_TYPE_CIRRUS;

+ if (!b_info->u.hvm.hdtype)

+            b_info->u.hvm.hdtype = LIBXL_HDTYPE_IDE;
+
          switch (b_info->device_model_version) {
          case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL:
              switch (b_info->u.hvm.vga.kind) {
diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index 33f9ce6..7eba4e6 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -818,6 +818,8 @@ static int libxl__build_device_model_args_new(libxl__gc *gc,
      flexarray_append(dm_args, libxl__sprintf(gc, "%"PRId64, ram_size));

if (b_info->type == LIBXL_DOMAIN_TYPE_HVM) {

+        if (b_info->u.hvm.hdtype == LIBXL_HDTYPE_AHCI)
+            flexarray_append_pair(dm_args, "-device", "ahci,id=ahci0");
          for (i = 0; i < num_disks; i++) {
              int disk, part;
              int dev_number =
@@ -872,7 +874,14 @@ static int libxl__build_device_model_args_new(libxl__gc 
*gc,
                      drive = libxl__sprintf
                          (gc, 
"file=%s,if=scsi,bus=0,unit=%d,format=%s,cache=writeback",
                           pdev_path, disk, format);
-                else if (disk < 4)
+                else if (disk < 6 && b_info->u.hvm.hdtype == 
LIBXL_HDTYPE_AHCI) {
+                    flexarray_vappend(dm_args, "-drive",
+                        
GCSPRINTF("file=%s,if=none,id=ahcidisk-%d,format=%s,cache=writeback",
+                        pdev_path, disk, format),
+                        "-device", 
GCSPRINTF("ide-hd,bus=ahci0.%d,unit=0,drive=ahcidisk-%d",
+                        disk, disk), NULL);
+                    continue;
+                } else if (disk < 4)
                      drive = libxl__sprintf
                          (gc, 
"file=%s,if=ide,index=%d,media=disk,format=%s,cache=writeback",
                           pdev_path, disk, format);
diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
index 23f27d4..d92ff0b 100644
--- a/tools/libxl/libxl_types.idl
+++ b/tools/libxl/libxl_types.idl
@@ -198,6 +198,11 @@ libxl_viridian_enlightenment = 
Enumeration("viridian_enlightenment", [
      (3, "reference_tsc"),
      ])

+libxl_hdtype = Enumeration("hdtype", [

+    (1, "IDE"),
+    (2, "AHCI"),
+    ], init_val = "LIBXL_HDTYPE_IDE")
+
  #
  # Complex libxl types
  #
@@ -439,6 +444,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
                                         ("nested_hvm",       libxl_defbool),
                                         ("smbios_firmware",  string),
                                         ("acpi_firmware",    string),
+                                       ("hdtype",           libxl_hdtype),
                                         ("nographic",        libxl_defbool),
                                         ("vga",              
libxl_vga_interface_info),
                                         ("vnc",              libxl_vnc_info),
diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index c858068..30e5f50 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -2146,6 +2146,17 @@ skip_vfb:
              b_info->u.hvm.vga.kind = l ? LIBXL_VGA_INTERFACE_TYPE_STD :
                                           LIBXL_VGA_INTERFACE_TYPE_CIRRUS;

+ if (!xlu_cfg_get_string (config, "hdtype", &buf, 0)) {

+            if (!strcmp(buf, "ide")) {
+                b_info->u.hvm.hdtype = LIBXL_HDTYPE_IDE;
+            } else if (!strcmp(buf, "ahci")) {
+                b_info->u.hvm.hdtype = LIBXL_HDTYPE_AHCI;
+            } else {
+                fprintf(stderr, "Unknown hdtype \"%s\" specified\n", buf);
+                exit(1);
+            }
+        }
+
          xlu_cfg_replace_string (config, "keymap", &b_info->u.hvm.keymap, 0);
          xlu_cfg_get_defbool (config, "spice", &b_info->u.hvm.spice.enable, 0);
          if (!xlu_cfg_get_long (config, "spiceport", &l, 0))



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

Prev by Date: Re: [Xen-devel] [PATCH]xen new latest version mp_register_lapic can't register disabled CPU, patch attempt to fix
Next by Date: Re: [Xen-devel] [PATCH v2 07/12] x86/altp2m: add control of suppress_ve.
Previous by thread: [Xen-devel] [linux-3.4 test] 59091: regressions - FAIL
Next by thread: Re: [Xen-devel] [PATCH v3] libxl: Add AHCI support for upstream qemu
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.