Re: [Xen-devel] [PATCH v3 1/7] libxl: get rid of the SEDF scheduler

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Mon, 2015-07-06 at 17:22 +0100, George Dunlap wrote:
> On 07/06/2015 05:17 PM, Dario Faggioli wrote:
> > On Mon, 2015-07-06 at 16:40 +0100, George Dunlap wrote:
> >> On 07/06/2015 04:30 PM, Dario Faggioli wrote:
> >>> only the interface is left in place, for backward
> >>> compile-time compatibility, but every attempt to
> >>> use it would throw an error.
> >>>
> >>> Signed-off-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
> >>> Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
> >>
> >> This probably should have been dropped...
> >>
> >>> Chenges from v2:
> >>>  - introduce and use ERROR_FEATURE_REMOVED, as requested
> >>>    during review;
> >>>  - mark the SEDF only parameter as deprecated in libxl_types.idl,
> >>>    as requested during review.
> >>
> >> ...given these.  One question:
> >>
> > Really? I'm basically only adding commentary, not changing (or adding,
> > or removing) a single line of code... I mean, the deprecation was
> > de-facto there already, since v1, it just was not stated explicitly
> > anywhere in that particular file.
> > 
> > That's why I didn't think a something like adding this comment would
> > call for removal of the tag.
> > 
> > Anyway, sorry for this. :-)
> 
> Not a big deal of course, and as it happens I wouldn't have minded if
> the patch went in as it is.  
>
Sure! :-)  I also was also just explaining my reasoning, rather than
complaining.

> But what if I hadn't liked the name of the
> error code?  It looks like I approve of it, which might sway some
> maintainer's view, when in fact I haven't expressed an opinion.
> 
Indeed, I see it know.

Thanks and Regards,
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel