Re: [Xen-devel] [v3 00/13] xen/arm: Add support for GICv2 on GICv3

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Thu, 2015-07-02 at 11:37 +0100, Julien Grall wrote:
> On 01/07/15 12:00, Julien Grall wrote:
> > Hi all,
> 
> Hi Ian,
> 
> > This patch series adds support for GICv2 on GICv3. This feature is available
> > only when the GICv3 hardware is compatible with GICv2.
> > 
> > When it's the case, the same interface is provided in order to use a
> > virtualize GICv2 (i.e GICC and GICV). This will allow us to re-use the
> > same vGIC driver.
> > 
> > Currently GIC and vGIC drivers are tight because of the domain 
> > initialization
> > splitted between GIC and vGIC. This patch series intends to remove this
> > dependency in order to make the vGIC driver agnostic of the GIC driver.
> > 
> > It has been tested on the ARMv8 Foundation Model with GICv2 and GICv3 as
> > well as changing the vGIC version emulated for the guest (only on GICv3 
> > host).
> > 
> > A branch with all the patches can be found here:
> >     git://xenbits.xen.org/people/julieng/xen-unstable.git branch 
> > gicv2-on-gicv3-v3
> > 
> > All the patches as been acked except #11 and #12.
> 
> I was wondering if you can apply patch #1-#10 as they are already acked.
> It would avoid me to resend the whole series.

Done.

There was one wrinkle, which is that the message-id's skipped #2, for
some reason. So I have applied
<1435748473-28812-NN-git-send-email-julien.grall@xxxxxxxxxx>
for NN==2 (patch 1, due to 00 being NN=1, which is normal)  and
NN=4..13 inclusive, being patches 2..11, acking patch 11.

I don't know how you convinced git send-email to do this, but I only
mention it in such detail so you can check I've applied the right
things...

> If you ack #11, you could even apply #11 and #13 (#12 is independent).

I did not apply #13 since it seemed to depend on #12:
gic-v3.c: In function 'gicv3_restore_state':
gic-v3.c:385:30: error: 'struct <anonymous>' has no member named 'version'
     if ( v->domain->arch.vgic.version == GIC_V2 )
                              ^
gic-v3.c: In function 'gicv3_update_lr':
gic-v3.c:893:36: error: 'struct <anonymous>' has no member named 'version'
     if ( current->domain->arch.vgic.version == GIC_V3 )
                                    ^
make[4]: *** [gic-v3.o] Error 1




> 
> Regards,
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel