Re: [Xen-devel] [PATCH OSSTEST v2] mg-all-branch-statuses: Show how up to date each branch is

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-07-01 at 15:35 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH OSSTEST v2] mg-all-branch-statuses: Show how 
> up to date each branch is"):
> > On Wed, 2015-07-01 at 14:37 +0100, Ian Jackson wrote:
> > > These ????-??-?? are quite visually noisy.
> > 
> > Agreed, I did consider just omitting them. Or would you prefer
> > "Unknown"?
> 
> It's not so much unknown as n/a.

Do you prefer the script to say "n/a" rather than nothing?

> > >   And the ISO dates are not
> > > ideal for reading - how about printing a number of days ago instead ?
> > 
> > I was a bit lazy and it was easier to get date(1) to give me a date from
> > shell. I'll see if I can get the number of days ago out of it by
> > extending the Perl.
> 
> Ah.  Number of days is easy:
[...]

Thanks.

> > > > linux-next                2e0a48c9             0  219 ????-??-?? 
> > > > 2014-04-10
> > > 
> > > I'm not sure what this means.  219 in #Tot would normally be a problem
> > > and `1stNew' is from 2014.  But linux-next is not fast-forwarding.
> > > And there's allegedly no tip although I think maybe you mean there is
> > > no basis.
> > 
> > Lack of quoting on the call to printf may have confused things due to
> > empty parameters.
> 
> Ah.
> 
> > Quoting things results in:
> > 
> > linux-next                            2e0a48c9    0  219 ????-??-?? 
> > 2014-04-10
> > 
> > Should basis say "None" in this case IYO?
> 
> I think blank is fine but I don't mind None.

I went with blank for no-basis.

> > > > osstest                   15d2dd50             0    - ????-??-?? 
> > > > ????-??-??
> > > 
> > > Is the lack of a Tip here a bug ?
> > 
> > I think it (ap-fetch-version) is looking in my $HOME and not osstest's.
> > I would expect this to be correct if I ran it as osstest.
> 
> So it broke ?  Shouldn't the script bomb out ?

That would be quite annoying since osstest.git is a bit odd/special in
its desire to be in $HOME/testing.git which not everyone will have.

Perhaps if we were to decide this was to be a cron only thing (and not
an end user script) I should a) rename it to cr-* and b) make it fail in
this case instead.

If it is to remain an mg-* then I could make it say "Error!" perhaps?

> > > > xen-4.5-testing           e3bd3cef e3bd3cef
> > > 
> > > You could replace one copy of `e3bd3cef' with `same' or soemthing.
> > 
> > Or "UpToDate" ?
> 
> For example.
> 
> Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel