[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH OSSTEST v2] mg-all-branch-statuses: Show how up to date each branch is



On Wed, 2015-07-01 at 14:37 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v2] mg-all-branch-statuses: Show how up 
> to date each branch is"):
> > Using report_find_push_age_info allows us to provide counts of
> > attempts since the last baseline on current tip as well as the first
> > attempt of each of those.
> > 
> > Since everything serialises on the repo lock I didn't bother trying to
> > parallelise anything.
> > 
> > It's a little terse to keep it in 80 chars.
> 
> Thanks.  This is useful.
> 
> > I did wonder about adding this to some cronjob or something.
> > 
> > Example output:
> > Branch                       Basis    Tip      #Tip #Tot 1stTip     1stNew
> > libvirt                   d10a5f58 ebd62eba    0    9 ????-??-?? 2015-06-23
> > linux-3.0                 e1c63f9f 5dba9ddd    1    8 2015-06-30 2013-02-13
> 
> These ????-??-?? are quite visually noisy.

Agreed, I did consider just omitting them. Or would you prefer
"Unknown"?

>   And the ISO dates are not
> ideal for reading - how about printing a number of days ago instead ?

I was a bit lazy and it was easier to get date(1) to give me a date from
shell. I'll see if I can get the number of days ago out of it by
extending the Perl.

> 
> > linux-next                2e0a48c9             0  219 ????-??-?? 2014-04-10
> 
> I'm not sure what this means.  219 in #Tot would normally be a problem
> and `1stNew' is from 2014.  But linux-next is not fast-forwarding.
> And there's allegedly no tip although I think maybe you mean there is
> no basis.

Lack of quoting on the call to printf may have confused things due to
empty parameters.

Quoting things results in:

linux-next                            2e0a48c9    0  219 ????-??-?? 2014-04-10

Should basis say "None" in this case IYO?

> 
> > osstest                   15d2dd50             0    - ????-??-?? ????-??-??
> 
> Is the lack of a Tip here a bug ?

I think it (ap-fetch-version) is looking in my $HOME and not osstest's.
I would expect this to be correct if I ran it as osstest.

Should it say "Unknown"?

> > xen-4.5-testing           e3bd3cef e3bd3cef
> 
> You could replace one copy of `e3bd3cef' with `same' or soemthing.

Or "UpToDate" ?

> 
> Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.