Re: [Xen-devel] [PATCH] xen: Install unstripped version -syms version into /usr/lib/debug

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.06.15 at 11:55, <ian.campbell@xxxxxxxxxx> wrote:
> On Fri, 2015-06-26 at 10:48 +0100, Andrew Cooper wrote:
>> > +BOOT_DIR defaults to /boot, DERBUG_DIR defaults to /usr/lib/debugt and
>> 
>> DERBUG and /debugt
> 
> Gah!
> 
>> > +EFI_DIR to /usr/lib64/efi.
>> >  BOOT_DIR=
>> > +DEBUG_DIR=
>> >  EFI_DIR=
>> >  
>> >  The make target 'rpmball' will build a xen.rpm. This variable can be
>> > diff --git a/config/StdGNU.mk b/config/StdGNU.mk
>> > index f47c238..39d36b2 100644
>> > --- a/config/StdGNU.mk
>> > +++ b/config/StdGNU.mk
>> > @@ -27,6 +27,7 @@ INSTALL_DATA = $(INSTALL) -m0644 -p
>> >  INSTALL_PROG = $(INSTALL) -m0755 -p
>> >  
>> >  BOOT_DIR ?= /boot
>> > +DEBUG_DIR ?= /usr/lib/debug
>> 
>> While I hate to day it, this probably needs /local/ handling for
>> non-system builds, and this sounds autoconf'y.  How stable is the path
>> across different systems?
> 
> This is used in xen/Makefile so autoconf is off the cards. So far we
> already have BOOT_DIR and EFI_DIR which are special in this way. IMHO
> adding DEBUG_DIR is fine. I don't think we will need this for tools/*
> since what should happen there is we install the unstripped things (if
> asked to do so) as usual and then the rpm/deb packaging tools will take
> care of creating the detached debug info if they care. Normal users will
> just get the stripped or unstripped versions install depending on what
> they asked for.

+1

With the typos fixed
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel