[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH OSSTEST v2 05/19] Refactor pxelinux configuration
Ian Campbell writes ("Re: [PATCH OSSTEST v2 05/19] Refactor pxelinux configuration"): > On Thu, 2015-06-18 at 18:49 +0100, Ian Jackson wrote: > > Are you expecting to introduce setup_FIRMWARE_SOMETHINGELSE ? > > I think initially I was initially expecting to but ended up not needing > to. > > I will assume you would also prefer "setup_${firmware}_pxeboot_local" to > become "setup_pxeboot_local_${firmware}" (rather than "setup_pxeboot_ > ${firmware}_local"). Yes. (Do we mean `pxeboot' or `netboot'?) > > > + $xopts{ipappend} = $ipappend; > > > + setup_pxeboot($ho, $kernel, "/$initrd", $dicmd, $hocmd, %xopts); > > > > Perhaps setup_pxeboot (which maybe should be renamed?) should do the > > joining ? You could pass \@dicmdline and \@hocmdline. > > Good idea. > > Do you think setup_pxeboot maybe ought to be setup_pxeboot_di or > something along those lines? Quite possibly, yes. Or maybe setup_netboot_di. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |