Re: [Xen-devel] [PATCH OSSTEST v2 05/19] Refactor pxelinux configuration

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH OSSTEST v2 05/19] Refactor pxelinux 
configuration"):
> The mechanism used to PXE boot can differ depending on the firmware
> type. Therefore refactor into Osstest::TestSupport and key off a new
> host property "firmware".
> 
> Currently supported is "bios" (the default) and "uboot", both of which
> use pxelinux.cfg style files.
> 
> The default for the firmware property is "bios", hence no change for
> any existing system (including those which use uboot, regardless of
> whether they are now configured with the firmware proprty or not)

> +    return 
> &{"setup_${firmware}_pxeboot"}($ho,$kern,$initrd,$dicmd,$hocmd,%xopts);

Are you expecting to introduce setup_FIRMWARE_SOMETHINGELSE ?

AFIACT not, in which case this name is quite confusing.  Putting the
variable part at the end would be much clearer:
setup_pxeboot_${firmware}.

> @@ -287,18 +288,8 @@ END
>      my $dicmd= join ' ', @dicmdline;
>      my $hocmd= join ' ', @hocmdline;
...
> +    $xopts{ipappend} = $ipappend;
> +    setup_pxeboot($ho, $kernel, "/$initrd", $dicmd, $hocmd, %xopts);

Perhaps setup_pxeboot (which maybe should be renamed?) should do the
joining ?  You could pass \@dicmdline and \@hocmdline.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel